Fixes pixel offsets once and for all #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Story Content
MrMelbert
added
Adjustment
Fixes #89481 I removed the code which de-elevated vehicles Also `TRAIT_NO_FLOATING_ANIMATION` continues to be a burden, causing the offset to reset. I fixed that as well. :cl: Melbert fix: Fixed offset during vehicle traversal over boxes and tables, as well as while floating /:cl:
Speedbikes, wheelchairs and speedwagon have separate cover overlays - this just made them render ontop of owners. Closes tgstation/tgstation#89481 🆑 fix: Fixed broken layering on some vehicles /🆑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being sick and tired of mob offsets being rather glitchy, particularly involving buckling and riding, I sought out to resolve it
I did this by making pixel offsets tracked via sources
I also refactored riding to make it easier to work around
Now it's super smooth and you pick someone up and they don't teleport around and you can grab them by the neck and buckle them to an operating table and it all just works ™️